Sync collaboration mode naming across Default prompt, tools, and TUI#10666
Merged
charley-oai merged 3 commits intomainfrom Feb 5, 2026
Merged
Sync collaboration mode naming across Default prompt, tools, and TUI#10666charley-oai merged 3 commits intomainfrom
charley-oai merged 3 commits intomainfrom
Conversation
Collaborator
Author
|
@codex review this |
Contributor
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sayan-oai
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModeKindhelpers for display names, TUI visibility, andrequest_user_inputavailabilityModeKindmetadata instead of local hardcoded matchesrequest_user_inputavailability text and unavailable error mode names from shared mode metadata{{KNOWN_MODE_NAMES}}and fill it fromTUI_VISIBLE_COLLABORATION_MODESNotes
cargo test -p codex-coreintegration target (tests/all) still shows pre-existing env-specific failures in this environment due missingtest_stdio_serverbinary resolution; core unit tests are green.Codex author
codex resume 019c26ff-dfe7-7173-bc04-c9e1fff1e447